Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Perpetually Valid Signed Voluntary Exits #7044

Merged
merged 11 commits into from
Jun 24, 2023
Merged

Add EIP: Perpetually Valid Signed Voluntary Exits #7044

merged 11 commits into from
Jun 24, 2023

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented May 18, 2023 •
edited
Loading

todo:

  • assign number

@dapplion dapplion requested a review from eth-bot as a code owner May 18, 2023 16:15
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels May 18, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 18, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels May 18, 2023
@dapplion dapplion force-pushed the exit-perpetual-valid branch 3 times, most recently from 09b3af7 to 788b596 Compare May 18, 2023 16:24
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 18, 2023
g11tech
g11tech reviewed May 18, 2023
View reviewed changes
EIPS/eip-7044.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed May 18, 2023
View reviewed changes
EIPS/eip-7044.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed May 18, 2023
View reviewed changes
EIPS/eip-7044.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed May 18, 2023
View reviewed changes
EIPS/eip-7044.md Outdated

### Consensus Layer

The mechanics of the specification can be found in the [Consensus Layer specs](https://github.com/ethereum/consensus-specs/pull/3288).
Copy link
Contributor

@g11tech g11tech May 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to refer to a blob commit of the relevant content rather than a PR (once PR is merged i guess)

Copy link
Contributor

@g11tech g11tech May 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dapplion we are modifying the regex to support the compare diffs in drafts instead of PRs as the diffs are static: so basically this for your PR: https://github.com/ethereum/consensus-specs/compare/1c35eb1c3303fe1e0b101323106d766d8f848cd6~3...1c35eb1c3303fe1e0b101323106d766d8f848cd6 which is this link

g11tech
g11tech reviewed May 18, 2023
View reviewed changes
EIPS/eip-7044.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed May 19, 2023
View reviewed changes
EIPS/eip-7044.md Outdated Show resolved Hide resolved
@poojaranjan poojaranjan mentioned this pull request May 30, 2023
Closed
23 tasks
@zah
Copy link

zah commented May 30, 2023

I suspect this EIP is trying to address a common problem faced by staking pool operators: How can their customers be sure that the operator won't keep the created validators active forever (this allows the operator to profit from transaction fees and MEV)?

To solve this problem in a more comprehensive way, it may be beneficial to also introduce a new type of exit message that identifies the exited validator by their public key. This is an improvement because it will allow the staking pool to share the signed exit message with the staker before the staker has committed to fund the created validator. This is not easy to do otherwise, because the final validator index is now known until the deposit has been processed by the beacon chain.

I've written more about this here:
ethereum/consensus-specs#2666

One possible work-around with significant downsides is to require the operator to sign a very wide range of exit messages that target all possible validator indices.

@hwwhww hwwhww mentioned this pull request Jun 2, 2023
Open
@g11tech g11tech mentioned this pull request Jun 20, 2023
Merged
@SamWilsn SamWilsn closed this Jun 22, 2023
@SamWilsn SamWilsn reopened this Jun 22, 2023
@g11tech
Copy link
Contributor

g11tech commented Jun 23, 2023

@eth-bot rerun

djrtwo
djrtwo reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some clean-ups in language and links to get this thing mergeddd

EIPS/eip-7044.md Outdated Show resolved Hide resolved
EIPS/eip-7044.md Outdated Show resolved Hide resolved
EIPS/eip-7044.md Outdated Show resolved Hide resolved
EIPS/eip-7044.md Outdated

### Consensus Layer

The mechanics of the specification can be found in the [Consensus Layer specs](https://github.com/ethereum/consensus-specs/commit/14212958d3605c5dd4f8ab617f157328f53ce559).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specification changes are built into the Consensus Specs Deneb upgrade.

The specific makes one change to the state transition function:

Additionally, the voluntary_exit gossip conditions are implicitly modified to support this change.

EIPS/eip-7044.md Outdated Show resolved Hide resolved
EIPS/eip-7044.md Outdated Show resolved Hide resolved
EIPS/eip-7044.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 24, 2023
@github-actions
Copy link

The commit 1c11651 (as a parent of 6500963) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 24, 2023
@g11tech
Copy link
Contributor

g11tech commented Jun 24, 2023 •
edited
Loading

rebased via UI to check the link validation, is now successful @dapplion

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 24, 2023
g11tech
g11tech approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eth-bot eth-bot enabled auto-merge (squash) June 24, 2023 12:24
eth-bot
eth-bot approved these changes Jun 24, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 54da9c4 into ethereum:master Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@djrtwo djrtwo djrtwo left review comments

@eth-bot eth-bot eth-bot approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dapplion @eth-bot @zah @g11tech @djrtwo @abcoathup @SamWilsn